GH-47784: [C++] Patch vendored pcg library to enable msvc arm64 intrinsics#47779
Merged
pitrou merged 1 commit intoapache:mainfrom Oct 15, 2025
jgiannuzzi:windows-arm64-cpp
Merged
GH-47784: [C++] Patch vendored pcg library to enable msvc arm64 intrinsics#47779pitrou merged 1 commit intoapache:mainfrom jgiannuzzi:windows-arm64-cpp
pitrou merged 1 commit intoapache:mainfrom
jgiannuzzi:windows-arm64-cpp
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This change enables building Arrow C++ for Windows ARM64 with MSVC when setting
ARROW_SIMD_LEVELtoNONE. This is useful to be able to build Arrow withvcpkgand use it as a dependency.Setting
ARROW_SIMD_LEVELtoNONEis done to disable the use ofxsimd, which does not yet support msvc arm64 intrinsics, and is non-trivial to fix.What changes are included in this PR?
A patch to the vendored
pcglibrary, based on imneme/pcg-cpp#99. The upstream pcg library has not been updated in the past 3 years, so this may never get merged.Are these changes tested?
Yes, the changes have been tested in microsoft/vcpkg#47750 (the same patch for
vcpkg, which this change would alleviate) and in https://github.com/jgiannuzzi/ParquetSharp/actions/runs/18354286294 (a full run of the ParquetSharp CI, using this patch to build Arrow withvcpkg).Are there any user-facing changes?
Not really, unless you consider adding the ability to build Arrow on Windows ARM64 user-facing?